omicron/d2warehouse
1
0
Fork 1
Code Issues 4 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix showing/counting items that are socketed into other items #10

Open
omicron wants to merge 1 commits from fix_item_counting into main
pull from: fix_item_counting
merge into: omicron:main
Conversation 0 Commits 1 Files Changed 1 +22 -9
omicron commented 2025-10-02 17:24:57 +00:00
Owner
Copy Link

This is a partial fix for #8. It stops the UI from showing those items and in that sense it also prevents the UI from taking them out. What should still be done (probably in refactoring for #9) is:

  • Straight up disallowing you to take out items that are socketed
  • Making sure the socketed items are marked deleted when we withdraw items
This is a partial fix for #8. It stops the UI from showing those items and in that sense it also prevents the UI from taking them out. What should still be done (probably in refactoring for #9) is: - Straight up disallowing you to take out items that are socketed - Making sure the socketed items are marked deleted when we withdraw items
omicron added 1 commit 2025-10-02 17:24:57 +00:00
Fix showing/counting items that are socketed into other items 1cb9ff63e7
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix_item_counting:fix_item_counting
git checkout fix_item_counting
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
internals
This issue relates to system internals
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
omicron
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: omicron/d2warehouse#10
No description provided.
Delete Branch "fix_item_counting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?