Storage system abstraction is needed #9

New Issue

omicron · 2025-10-02T12:19:44Z

omicron commented

2025-10-02 12:19:44 +00:00

Currently the item<>stash interaction seems nicely abstracted away but the storage system is much more messy. The item<>storage interactions are interspersed in the web ui application code. There should probably be a storage abstraction of some kind.

On top of that, I'm not a huge fan of the complex item storage we have now since it makes the system fragile (for example see #8). It's not immediately clear to me why we need to have for example each socketed item stored separately. On top of that I'm also not sure we should be trying to re-create items from the database properties instead of just reading them directly from the raw item bytes. The latter would reduces the different ways items can be created to a single place and makes it harder to create inconsistencies.

Currently the item<>stash interaction seems nicely abstracted away but the storage system is much more messy. The item<>storage interactions are interspersed in the web ui application code. There should probably be a storage abstraction of some kind. On top of that, I'm not a huge fan of the complex item storage we have now since it makes the system fragile (for example see #8). It's not immediately clear to me why we need to have for example each socketed item stored separately. On top of that I'm also not sure we should be trying to re-create items from the database properties instead of just reading them directly from the raw item bytes. The latter would reduces the different ways items can be created to a single place and makes it harder to create inconsistencies.

omicron added the

internals

label 2025-10-02 12:19:44 +00:00

omicron referenced this issue

2025-10-02 17:24:57 +00:00

Fix showing/counting items that are socketed into other items #10

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: omicron/d2warehouse#9