wow/OmicronFrames
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

AuraTrigger:IsMatching has a possibly redundant check #8

New Issue
Open
opened 2026-03-18 00:11:24 +00:00 by omicron · 0 comments
omicron commented 2026-03-18 00:11:24 +00:00
Owner
Copy Link
Copy Source

In AuraTrigger:IsMatching there is an incorrect check that checks the spell id. However, this doesn't actually cause issues because the AuraList will keep track of checking which trigger reacts to which spells. It seems the check there is redundant and I'm not sure why it was there in the first place. This needs to be more thoroughly thought about before a decision is made either way.

In AuraTrigger:IsMatching there is an incorrect check that checks the spell id. However, this doesn't actually cause issues because the AuraList will keep track of checking which trigger reacts to which spells. It seems the check there is redundant and I'm not sure why it was there in the first place. This needs to be more thoroughly thought about before a decision is made either way.
omicron added the
Status
Need More Info
2
Kind/Internals labels 2026-03-18 00:11:24 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Internals
Internals changes
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Kind/Internals
Status
Need More Info
2
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
omicron
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wow/OmicronFrames#8
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?